Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #244

Merged
merged 3 commits into from
May 2, 2024
Merged

Upgrade dependencies #244

merged 3 commits into from
May 2, 2024

Conversation

Danielius1922
Copy link
Member

@Danielius1922 Danielius1922 commented May 2, 2024

Summary by CodeRabbit

  • Chores
    • Updated the linting tool to a newer version for improved code quality checks.
  • Refactor
    • Removed specific linters and adjusted file exclusions to streamline code analysis processes.

golangci/golangci-lint-action: v4 -> v5
Copy link

coderabbitai bot commented May 2, 2024

Walkthrough

The changes primarily involve updating the version of the GolangCI-Lint action in the GitHub workflow and modifying the linting configuration by removing a linter and excluding certain files. These updates are aimed at improving the code quality checks and maintaining compatibility with newer versions.

Changes

Files Change Summary
.github/workflows/.../golangci-lint.yml Updated golangci/golangci-lint-action from v4 to v5.
.golangci.yml Removed gomoddirectives linter; excluded files ending in .pb.go and .pb.gw.go.

Possibly related issues

  • Issue Dependency Dashboard #6: The update of golangci/golangci-lint-action in this PR might be part of the broader updates and dependency management mentioned in the issue, which includes updating various GitHub actions.
  • Issue plgd-dev/device-provisioning-service#217: The update to the linting configuration might align with the focus on updating and managing dependencies effectively as described in the issue.

🐇 A Poem by CodeRabbit

In the land of code, where the bits align,
A rabbit hopped through, making changes fine.
With a flick of its tail, a new version in sight,
Linters adjusted, with much delight.
Hop, skip, a commit, then push,
Clean code in the meadow, under the star's whoosh. 🌟🌿


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8f555bc and 52d9044.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (3)
  • .github/workflows/golangci-lint.yml (1 hunks)
  • .golangci.yml (3 hunks)
  • dependency/googleapis (1 hunks)
Files skipped from review due to trivial changes (3)
  • .github/workflows/golangci-lint.yml
  • .golangci.yml
  • dependency/googleapis

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Submodule:
github.com/google/googletest 7002406181eb300da880701035a25157a5099abb

Direct:
github.com/pion/dtls/v2 v2.2.8-0.20240501061905-2c36d63320a0
github.com/plgd-dev/device/v2 v2.5.1-0.20240502072920-6021006ea86b
github.com/plgd-dev/go-coap/v3 v3.3.4
github.com/plgd-dev/hub/v2 v2.18.1-0.20240502083717-331c4dbb67d7
google.golang.org/grpc v1.63.2
google.golang.org/protobuf v1.34.0

Indirect:
github.com/bufbuild/protocompile v0.13.0
github.com/go-co-op/gocron/v2 v2.3.0
github.com/jhump/protoreflect v1.16.0
github.com/klauspost/compress v1.17.8
go.mongodb.org/mongo-driver v1.15.0
go.opentelemetry.io/proto/otlp v1.2.0
golang.org/x/crypto v0.22.0
golang.org/x/exp v0.0.0-20240416160154-fe59bbe5cc7f
golang.org/x/mod v0.17.0
golang.org/x/net v0.24.0
golang.org/x/oauth2 v0.19.0
golang.org/x/sync v0.7.0
golang.org/x/sys v0.19.0
golang.org/x/term v0.19.0
golang.org/x/tools v0.20.0
google.golang.org/api v0.172.0
google.golang.org/genproto/googleapis/api v0.0.0-20240429193739-8cf5692501f6
google.golang.org/genproto/googleapis/rpc v0.0.0-20240429193739-8cf5692501f6
@Danielius1922 Danielius1922 force-pushed the adam/feature/update-deps branch from f40ed02 to 6849d7a Compare May 2, 2024 08:45
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Danielius1922 Danielius1922 marked this pull request as ready for review May 2, 2024 10:10
@Danielius1922 Danielius1922 merged commit 5d0ee35 into main May 2, 2024
13 of 14 checks passed
@Danielius1922 Danielius1922 deleted the adam/feature/update-deps branch May 2, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant